Skip to content

request and set the csrf header protection added to brooklyn server#37

Merged
asfgit merged 1 commit intoapache:masterfrom
ahgittin:use-csrf-headers
Nov 16, 2016
Merged

request and set the csrf header protection added to brooklyn server#37
asfgit merged 1 commit intoapache:masterfrom
ahgittin:use-csrf-headers

Conversation

@ahgittin
Copy link
Copy Markdown
Contributor

Minor tweaks to opt-in to CSRF protection in Brooklyn UI

NB requires apache/brooklyn-server#430
(actually it will work fine without that, but it will be no-op)

@geomacy
Copy link
Copy Markdown
Contributor

geomacy commented Nov 16, 2016

+1 looks good to me to the best of my knowledge. See comment on apache/brooklyn-server#430.

ahgittin added a commit to ahgittin/brooklyn-ui that referenced this pull request Nov 16, 2016
@asfgit asfgit merged commit 8c21530 into apache:master Nov 16, 2016
@bostko
Copy link
Copy Markdown
Contributor

bostko commented Nov 22, 2016

@ahgittin this breaks logout button :(

@ahgittin
Copy link
Copy Markdown
Contributor Author

@bostko oh no - pretty sure i tried that but will check

@geomacy
Copy link
Copy Markdown
Contributor

geomacy commented Nov 24, 2016

I didn't check it unfortunately - tried other things but don't normally hit the logout button.

@bostko
Copy link
Copy Markdown
Contributor

bostko commented Nov 24, 2016

Sorry for disturbing you I think I am wrong that this exactly broke it.
Please accept that as a reminder to test logout.
Logout htaccess can be broken in numerous ways...

@ahgittin
Copy link
Copy Markdown
Contributor Author

@bostko what is the problem you're encountering?

i've just tested, running BrooklynJavascriptGuiLauncher with this in my brooklyn.properties:

brooklyn.webconsole.security.users=admin
brooklyn.webconsole.security.user.admin.password=nimda
brooklyn.webconsole.security.provider=org.apache.brooklyn.rest.security.provider.ExplicitUsersSecurityProvider

logout seems to work fine in every permutation i've tried. note there were some changes to LogoutResource in apache/brooklyn-server#430 -- i did my testing with them ... they're now in master so shouldn't the issue but might be?

@ahgittin
Copy link
Copy Markdown
Contributor Author

i see, the problem is the swagger page, @bostko you're addressing in #36 -- commented there

(in general logout is working okay and this PR we think is fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants