Add cloudberry-env.sh file and replacing greenplum-path.sh#300
Add cloudberry-env.sh file and replacing greenplum-path.sh#300tuhaihe merged 1 commit intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Hiiii, @leborchuk welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
|
I haven't changed here i18n/zh/docusaurus-plugin-content-docs directory. Maybe these content should also need to be changed. Also, I just changed greenplum_path.sh -> cloudberry-env.sh. We discussed adding a notice (for creating symbolic link greenplum_path.sh -> cloudberry-env.sh) for former Greenplum users, but I cannot decide where to place it. For future years of the Cloudberry project, this notice seems irrelevant. So we could announce it on a blog post, and search engines would index it, and that would be enough. |
Hi @leborchuk, thanks for your contribution. I think we should only modify the current documentation branch, not 2.x. For 2.x, we can update it once the 2.1 release is out. Otherwise, users will encounter failures when using the command under the 2.0 release. |
The changes will be made in a future Apache Cloudberry release to ensure compliance with Apache Software Foundation guidelines. See details in discussion [Bug] Rename greenplum_path.sh and generate-greenplum-path.sh to remove trademarked references #1149 mailing list https://lists.apache.org/thread/b8o974mnnqk6zpy86dgll2pgqcvqgnwm PR could be merged after apache/cloudberry#1166
|
Since @leborchuk has no further response for this PR, I will merge this PR. For further updates, I will create a new PR on them. |
|
Oops, sorry, I missed this PR, thank you for merging it! |
That’s ok. Thanks for your work again! |
The changes will be made in a future Apache Cloudberry release to ensure compliance with Apache Software Foundation guidelines.
See details in
discussion [Bug] Rename greenplum_path.sh and generate-greenplum-path.sh to remove trademarked references #1149 mailing list https://lists.apache.org/thread/b8o974mnnqk6zpy86dgll2pgqcvqgnwm
PR could be merged after apache/cloudberry#1166
closes: #ISSUE_Number
Change logs
Contributor's checklist
Here are some reminders before you submit your pull request: