Add cloudberry-env.sh

[leborchuk]

Add cloudberry-env.sh file and replacing greenplum-path.sh

The changes will be made in a future Apache Cloudberry release to
ensure compliance with Apache Software Foundation guidelines.

See details in

• discussion [Bug] Rename greenplum_path.sh and generate-greenplum-path.sh to remove trademarked references #1149
• mailing list https://lists.apache.org/thread/b8o974mnnqk6zpy86dgll2pgqcvqgnwm

Fixes #1149

[tuhaihe]

Hi, there is one PR on the notice blog post about the file renaming: apache/cloudberry-site#294. Welcome to take a look! Thanks. @leborchuk @yjhjstz (Also, see https://lists.apache.org/thread/b8o974mnnqk6zpy86dgll2pgqcvqgnwm)

We need to finalize the renamed file name. If it looks good, we can publish the blog and continue the renaming work.

[tuhaihe]

For the file renaming, we need to replace all the strings related to greenplum_path in the source code completely, not just these three places. So it's a huge work and needs more care. Thanks @leborchuk!

[leborchuk]

For the file renaming, we need to replace all the strings related to greenplum_path in the source code completely, not just these three places. So it's a huge work and needs more care. Thanks @leborchuk!

Yep, I see 85 greenplum_path occurencies of greenplum_path in a source code

xifos@xifos-dev-jammy:~/git/cloudberry$ grep -l -r greenplum_path * | wc -l
85

What I am going to do is replace them in the next PR. I have already checked these PR in my development environment and wanted to move forward step by step.

Is it OK? (I still could replace all occurrences in one PR if needed)

[leborchuk]

Sorry for the noise here. The file generate-greenplum-path.sh has been changed, so I should rebase. I left generate-greenplume-path.sh as-is with the "NOTICE from the Apache Cloudberry PPMC".

I think we will delete it when all the work is done.

[tuhaihe]

For the file renaming, we need to replace all the strings related to greenplum_path in the source code completely, not just these three places. So it's a huge work and needs more care. Thanks @leborchuk!

Yep, I see 85 greenplum_path occurencies of greenplum_path in a source code

xifos@xifos-dev-jammy:~/git/cloudberry$ grep -l -r greenplum_path * | wc -l
85

What I am going to do is replace them in the next PR. I have already checked these PR in my development environment and wanted to move forward step by step.

Is it OK? (I still could replace all occurrences in one PR if needed)

‌Let's replace them all in this PR.

[tuhaihe]

Sorry for the noise here. The file generate-greenplum-path.sh has been changed, so I should rebase. I left generate-greenplume-path.sh as-is with the "NOTICE from the Apache Cloudberry PPMC".

I think we will delete it when all the work is done.

Since we're replacing all the old filenames in this PR, the NOTICE file becomes unnecessary. I recommend removing both the license headers and NOTICE references in this PR as well. @leborchuk FYI.

[leborchuk]

Sorry for the noise here. The file generate-greenplum-path.sh has been changed, so I should rebase. I left generate-greenplume-path.sh as-is with the "NOTICE from the Apache Cloudberry PPMC".
I think we will delete it when all the work is done.

Since we're replacing all the old filenames in this PR, the NOTICE file becomes unnecessary. I recommend removing both the license headers and NOTICE references in this PR as well. @leborchuk FYI.

Yep, removed the NOTICE and all occurrences of greenplum_path that were found in the code. Some of them were manually executed scripts, like src/backend/gporca/scripts/get_debug_event_counters.py, or inside beehave tests. I just changed them using a sed script and didn't check if they still worked or not. I launched build&configure&create/destroy&check_world, and everything worked fine. I believe that should be enough )

[tuhaihe]

Sorry for the noise here. The file generate-greenplum-path.sh has been changed, so I should rebase. I left generate-greenplume-path.sh as-is with the "NOTICE from the Apache Cloudberry PPMC".
I think we will delete it when all the work is done.

Since we're replacing all the old filenames in this PR, the NOTICE file becomes unnecessary. I recommend removing both the license headers and NOTICE references in this PR as well. @leborchuk FYI.

Yep, removed the NOTICE and all occurrences of greenplum_path that were found in the code. Some of them were manually executed scripts, like src/backend/gporca/scripts/get_debug_event_counters.py, or inside beehave tests. I just changed them using a sed script and didn't check if they still worked or not. I launched build&configure&create/destroy&check_world, and everything worked fine. I believe that should be enough )

Cool! Thanks @leborchuk, will check it later.

[tuhaihe]

• gpAux/client/scripts/greenplum_clients_path.sh - This file also needs to be changed.

[tuhaihe]

@leborchuk thanks for your contribution. Just left a few comments, FYI.

[tuhaihe]

Also, I found we need to update the following line to pass the license check:

cloudberry/pom.xml

Line 304 in 6b96824

<exclude>gpMgmt/bin/generate-greenplum-path.sh</exclude>

.

[tuhaihe]

BTW, welcome to help review this PR: #1171. We need to add the license check to the CI workflow.

[leborchuk]

• gpAux/client/scripts/greenplum_clients_path.sh

Fixed, rename to cloudberry_clients_path

[tuhaihe]

• gpAux/client/scripts/greenplum_clients_path.sh

Fixed, rename to cloudberry_clients_path

Cool! The NOTICE header can be removed from /gpAux/client/scripts/cloudberry_clients_path.sh too. Thanks!

After this tweak, welcome to squash these commits into one, which would be better to have a good commit message body with enough context, and can take this template for reference.

Then, we can approve this PR and start to merge.

[leborchuk]

Remove NOTICE and squash changes.

I also opened apache/cloudberry-site#300 to fix the site docs - pls see it )

[tuhaihe]

Remove NOTICE and squash changes.

I also opened apache/cloudberry-site#300 to fix the site docs - pls see it )

Great! Thanks @leborchuk!