Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Conversation

@iceteabottle
Copy link
Contributor

@iceteabottle iceteabottle commented Oct 28, 2019

  • Add selection for disk offering
  • Format Info card for vm config summary
  • Add iso selection
  • Add tags to the templates (featured, public, etc.)
  • Sort templates/isos
  • Pin featured templates/isos at the top of each list
  • Add search filter input for isos/templates
  • Handle form change on switching from template to iso (and vice versa)
  • Add translations for all input placeholders
  • Implement submit method
  • Add affinity group selection
  • Add network selection
  • Add ssh key pairs selection
  • Handle Navigation (e.g. reset the form on navigating away)
  • Add filter possibility to selections (compute offering, disk offering, network offering, ...)

@yadvr yadvr added this to the v0.1 Technical Preview (Beta) milestone Oct 29, 2019
@yadvr
Copy link
Member

yadvr commented Oct 29, 2019

@iceteabottle thanks for resuming this. One request from last time I tested your component/form, can you add the device mixin to hide the infocard on mobile?

Florian Symanowski added 2 commits October 29, 2019 13:05
@iceteabottle
Copy link
Contributor Author

Current status:

localhost_5050_ (3)

@iceteabottle
Copy link
Contributor Author

@iceteabottle thanks for resuming this. One request from last time I tested your component/form, can you add the device mixin to hide the infocard on mobile?

Done.

Florian Symanowski added 3 commits October 29, 2019 18:05
@iceteabottle
Copy link
Contributor Author

Iso Selection (WIP):

Bildschirmfoto 2019-10-30 um 14 41 37

@iceteabottle
Copy link
Contributor Author

I updated the tagging of the isos.
Bildschirmfoto 2019-11-04 um 16 21 26

I plan to apply this tagging also for the template selection.

@yadvr
Copy link
Member

yadvr commented Nov 4, 2019

Nice @iceteabottle - do you think instead we could have an explicit tab of featured templates (use the star icon), rest looks great!

@iceteabottle
Copy link
Contributor Author

Nice @iceteabottle - do you think instead we could have an explicit tab of featured templates (use the star icon), rest looks great!

Thanks. Maybe I could pin the featured above instead of breaking the OS tabs logic. What do you think, @rhtyd ?

@yadvr
Copy link
Member

yadvr commented Nov 4, 2019

@iceteabottle that's good idea as well, so basically show features templates? However, per the old CloudStack templates have a sort order so I don't know if that would break anything esp. in env with large number of templates. cc @PaulAngus @svenvogel ?

@svenvogel svenvogel added the feature New Feature label Nov 5, 2019
@svenvogel
Copy link

@rhtyd Hi Rohit

in the old wizard there are these tabs. do you mean this one?
image

or

the order in the templates menu?
image

@yadvr
Copy link
Member

yadvr commented Nov 5, 2019

Hi @svenvogel in the second screenshot, the order is used to determine the sort order of a resource. CloudStack stores the order in sort_key in the data_center, vm_template and offerings related tables in the cloud db. This sort order is then used to render the sequence of items in the list API response by default, so whatever sort order the admin configures; the templates show up in the UI with that order for each tab (featured, community etc...)

@iceteabottle
Copy link
Contributor Author

@rhtyd I wrapped each inner wizard components into a collapsable item to improve the UX.
I will prepare my branch for @utchoang these days.

Bildschirmfoto 2020-01-27 um 16 03 35

@yadvr
Copy link
Member

yadvr commented Jan 30, 2020

@utchoang please pick this one next, in consultation with @iceteabottle and @svenvogel. Let me know if you've any questions or need any help.

@iceteabottle
Copy link
Contributor Author

@rhtyd Today I will add the last major form part "ssh key pairs selection" to finish the main layout stuff. Can you please merge this PR tomorrow? Then @utchoang can continue my work in his own fork.

@iceteabottle
Copy link
Contributor Author

Add SSH keypair selection.

Bildschirmfoto 2020-01-30 um 15 30 03

@svenvogel
Copy link

@utchoang can you resume here please?

@iceteabottle
Copy link
Contributor Author

@utchoang can you resume here please?

@utchoang please see my checklist #7 (comment)

@rhtyd please merge this PR so @utchoang can finish this feature.

Thanks for the cooperation in this project. I'm sorry that I have to discontinue my work here.

@utchoang
Copy link

utchoang commented Jan 31, 2020

@iceteabottle Thank you so much.
@svenvogel I will start working on it after @rhtyd finishes merging this PR.

@svenvogel
Copy link

@rhtyd can you merge that we can proceed?

@yadvr
Copy link
Member

yadvr commented Jan 31, 2020

@utchoang @svenvogel I'll squash merge this per your request, I've not tested it. Just checked and added license header to some files.

@yadvr yadvr merged commit f9cc6e1 into apache:master Jan 31, 2020
@yadvr
Copy link
Member

yadvr commented Jan 31, 2020

@utchoang you can continue on it now, raise a new PR. When you do checkout latest master, ensure it's same as origin master by doing:

git fetch origin master
git checkout master
git reset --hard origin/master
git checkout -b 'new-branch-name for your new PR'

utchoang referenced this pull request in utchoang/cloudstack-primate Jan 31, 2020
compute: work-in-progress VM deployment wizard (#7)
@iceteabottle iceteabottle deleted the feature/vm-wizard branch February 3, 2020 07:54
@utchoang utchoang mentioned this pull request Feb 18, 2020
17 tasks
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
This implements a work-in-progress VM deployment wizard.

Co-authored-by: Rohit Yadav <rohit@apache.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants