FIX - compute - Create snapshot from virtual machine with managed storage #808
Conversation
|
|
|
@rhtyd @svenvogel Please review it. Thanks. |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
|
@utchoang There also needs to be a check for |
|
@blueorangutan package |
|
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
|
@rhtyd @davidjumani is this ready to go? 😄 |
@davidjumani so what i see is that there is no squeezing in managed storage. we dont need at the moment an quiesed button. |
|
@blueorangutan package |
|
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
@davidjumani Please review again. Thank you. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
|
@davidjumani @utchoang maybe I am wrong but there is NO qiescevm on a managed storage volume. I don’t know if there is something in VMware but I think the mechanism is another one. Please refer #3724 in cloudstack. |
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
davidjumani
left a comment
davidjumani
left a comment
There was a problem hiding this comment.
LGTM. However, this needs to be tested on VMware
|
@davidjumani can you clarify where you use "quiescevm" in VMware and which feature you want to test? there are normal VM Snapshots and i only know volume snapshot like VVOLs. Do you speak about VVOLs (virtual volumes)? Can you link or clarify the test? Maybe we dont need an VMware test because there is no functionality they use the volume snapshot and qiescing. |
|
@svenvogel Not too sure about it but I do see it as a parameter in volume snapshot as well as while creating VMware snapshots |
|
@davidjumani how can we proceed? i see there is a parameter but which time it is used? take a look here. its included in the old UI. @rhtyd @utchoang @davidjumani is the master frozen? i think this is ready to merge. |
|
@davidjumani @rhtyd Do you test OK and ready to merge? |
|
Well, from what I understand, what it matters here is not the hypervisor (VMware). But the volume itself with quiescevm enabled. One can test it by mocking such situation. Also, the API returns such information on the list volumes call which enabled to implement the UI on same approach as the old UI. I don't see any problem here. |
|
I too don't see any blocker here since it works as expected but would like the snapshot API call tested on a volume with quiescevm enabled (mocked also works fine) |
|
@rhtyd @davidjumani @GabrielBrascher can we merge? @utchoang could do it. |
|
@rhtyd @davidjumani cc @svenvogel Is it possible to merge this PR? |
|
I'm okay with having this merged |
GabrielBrascher
left a comment
GabrielBrascher
left a comment
There was a problem hiding this comment.
Thanks for the PR @utchoang! LGTM
* master: Using post for uploadSslCert api (apache#842) Allow enabling network/vpc offering at creation (apache#911) Display all data volumes for vm while destroying (apache#915) tools/docker: Change directory to docker.sh's directory (apache#916) FIX - compute - Create snapshot from virtual machine with managed storage (apache#808) migratewizard: Fix fetching jobid from api response (apache#913) component: remove Primate name from the footer, fix bug report link migratewizard: Display error and unfreeze form when api call fails (apache#912) continue with the Zone deployment without shared primary storage (apache#908) # Conflicts: # src/components/page/GlobalFooter.vue
…rage (#808) * compute: add button and modal `take VM volume snapshot` * add awesome camera retro plugins * modified to using component * fix for quiescevm * add quiescevm to api params
6 participants
Fixes #807