Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Conversation

@Pearl1594
Copy link
Contributor

Backend PR: apache/cloudstack#4564

Additional field in Add Network Offering Form:
image

Additional field in Add VPC offering Form:
image

Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Thanks @Pearl1594

@yadvr yadvr modified the milestones: 1.0-GA, 1.1 Jan 8, 2021
@ravening
Copy link
Member

LGTM

@yadvr yadvr merged commit c8edbc3 into apache:master Jan 14, 2021
yadvr added a commit that referenced this pull request Jan 14, 2021
@yadvr
Copy link
Member

yadvr commented Jan 14, 2021

@Pearl1594 can you add an if check so the option is shown based on discovered api param?

qrry added a commit to qrry/cloudstack-primate that referenced this pull request Jan 14, 2021
* master:
  Using post for uploadSslCert api  (apache#842)
  Allow enabling network/vpc offering at creation (apache#911)
  Display all data volumes for vm while destroying (apache#915)
  tools/docker: Change directory to docker.sh's directory (apache#916)
  FIX - compute - Create snapshot from virtual machine with managed storage (apache#808)
  migratewizard: Fix fetching jobid from api response (apache#913)
  component: remove Primate name from the footer, fix bug report link
  migratewizard: Display error and unfreeze form when api call fails (apache#912)
  continue with the Zone deployment without shared primary storage (apache#908)

# Conflicts:
#	src/components/page/GlobalFooter.vue
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants