Fixup test_list_volumes.py failure

[vishesh92]

Description

This PR fixes intermittent test failures due left over volumes from previous test runs by waiting for their cleanup.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1411da1) 30.88% compared to head (49f385c) 26.10%.
Report is 6 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8392      +/-   ##
============================================
- Coverage     30.88%   26.10%   -4.78%     
+ Complexity    34079    27910    -6169     
============================================
  Files          5341     5341              
  Lines        374861   374861              
  Branches      54518    54518              
============================================
- Hits         115769    97865   -17904     
- Misses       243825   263898   +20073     
+ Partials      15267    13098    -2169     

Flag	Coverage Δ
simulator-marvin-tests	18.29% <ø> (-6.53%)	⬇️
uitests	4.39% <ø> (ø)
unit-tests	16.46% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sureshanaparti]

@vishesh92 can you update the description (about the issue, fix)

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8109

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sureshanaparti]

code lgtm

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8110

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[vishesh92]

@shwstppr @sureshanaparti After a discussion with @DaanHoogland, I have made changes to wait for cleanup of volumes after every test run to ensure that we don't have to wait for cleanup in all tests.

There might still be failures if some volume is not added in cleanup or there is a failure while cleaning up a volume.

[blueorangutan]

Packaging result [SF]: ✖️ el7 ✔️ debian. SL-JID 8112

[shwstppr]

@vishesh92 cc @DaanHoogland @sureshanaparti @weizhouapache
I do not like the idea of the listing tests failing if there are other resources present. I would prefer reverting the original PR to have stable results for the RC unless others are in line with the changes

[weizhouapache]

@vishesh92 cc @DaanHoogland @sureshanaparti @weizhouapache I do not like the idea of the listing tests failing if there are other resources present. I would prefer reverting the original PR to have stable results for the RC unless others are in line with the changes

+1

[DaanHoogland]

@vishesh92 cc @DaanHoogland @sureshanaparti @weizhouapache I do not like the idea of the listing tests failing if there are other resources present. I would prefer reverting the original PR to have stable results for the RC unless others are in line with the changes

I think the changes here are good. What PR do you mean to revert @shwstppr ?

[shwstppr]

@DaanHoogland #8281
Yes, changes in this are fine but even with them I won't be able to successfully run some of the tests added in #8281 if my env already has some resources

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8114

[yadvr]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[vishesh92]

Included in #8410