Add e2e tests for listing resources #8410

vishesh92 · 2023-12-28T06:17:58Z

Description

This PR adds e2e tests for listing resources and makes changes for simulator to use dualzone config in github actions workflow.

Recreating PR #8281 including fix from PR #8392.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…rics_api.py

…, service_offerings, storage_pools, volumes

vishesh92 · 2023-12-28T06:18:20Z

@blueorangutan package

blueorangutan · 2023-12-28T06:20:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2023-12-28T06:27:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d4f071) 30.80% compared to head (17a1e03) 30.85%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8410      +/-   ##
============================================
+ Coverage     30.80%   30.85%   +0.04%     
- Complexity    33981    34062      +81     
============================================
  Files          5341     5341              
  Lines        374864   374864              
  Branches      54518    54518              
============================================
+ Hits         115485   115668     +183     
+ Misses       244114   243952     -162     
+ Partials      15265    15244      -21

Flag	Coverage Δ
simulator-marvin-tests	`24.75% <ø> (+0.03%)`	⬆️
uitests	`4.39% <ø> (ø)`
unit-tests	`16.46% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2023-12-28T07:26:46Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8156

vishesh92 · 2023-12-28T07:31:07Z

@blueorangutan test matrix

blueorangutan · 2023-12-28T07:32:03Z

@vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2023-12-28T19:51:04Z

[SF] Trillian test result (tid-8690)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42844 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t8690-xenserver-71.zip
Smoke tests completed. 127 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_05_list_volumes_isrecursive	`Failure`	0.03	test_list_volumes.py
test_07_list_volumes_listall	`Failure`	0.03	test_list_volumes.py

blueorangutan · 2023-12-28T22:11:41Z

[SF] Trillian test result (tid-8691)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51160 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t8691-vmware-67u3.zip
Smoke tests completed. 127 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_balanced_drs_algorithm	`Error`	417.07	test_cluster_drs.py

vishesh92 · 2024-01-03T09:06:17Z

@blueorangutan package

blueorangutan · 2024-01-03T09:08:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-01-03T10:19:58Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8185

vishesh92 · 2024-01-03T11:39:59Z

@blueorangutan test matrix

blueorangutan · 2024-01-03T11:42:03Z

@vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-01-03T23:57:55Z

[SF] Trillian test result (tid-8715)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42534 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t8715-kvm-centos7.zip
Smoke tests completed. 128 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-01-04T00:33:12Z

[SF] Trillian test result (tid-8713)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44772 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t8713-xenserver-71.zip
Smoke tests completed. 128 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2024-01-04T10:51:01Z

the vmware version:

Smoke tests completed. 127 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_balanced_drs_algorithm	`Failure`	125.08	test_cluster_drs.py

harikrishna-patnala

code and smoke test results LGTM

DaanHoogland · 2024-02-06T08:55:43Z

@blueorangutan package

blueorangutan · 2024-02-06T08:56:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-06T10:01:46Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8541

DaanHoogland · 2024-02-06T11:01:37Z

@blueorangutan test matrix

blueorangutan · 2024-02-06T11:02:04Z

@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-02-06T23:14:18Z

[SF] Trillian test result (tid-9098)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42437 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t9098-xenserver-71.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-02-06T23:24:15Z

[SF] Trillian test result (tid-9100)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42975 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t9100-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

vishesh92 · 2024-02-07T04:57:36Z

[SF] Trillian test result (tid-9099)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51455 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8410-t9099-vmware-67u3.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache

code lgtm

* Use dualzones for ci github actions * Update advdualzone.cfg to be similar to advanced.cfg & fixup test_metrics_api.py * Fixup e2e tests for running with multiple zones * Add e2e tests for listing of accounts, disk_offerings, domains, hosts, service_offerings, storage_pools, volumes * Fixup * another fixup * Add test for listing volumes with tags filter * Add check for existing volumes in test_list_volumes * Wait for volumes to be deleted on cleanup * Filter out volumes in Destroy state before checking the count of volumes

vishesh92 added 9 commits December 28, 2023 11:45

Use dualzones for ci github actions

ffab74d

Update advdualzone.cfg to be similar to advanced.cfg & fixup test_met…

6828c7b

…rics_api.py

Fixup e2e tests for running with multiple zones

8eb82d7

Add e2e tests for listing of accounts, disk_offerings, domains, hosts…

716e00b

…, service_offerings, storage_pools, volumes

Fixup

464ca63

another fixup

3277a62

Add test for listing volumes with tags filter

c47f50e

Add check for existing volumes in test_list_volumes

7a2ba95

Wait for volumes to be deleted on cleanup

67d1d45

boring-cyborg bot added component:integration-test component:integration component:marvin Python Warning... Python code Ahead! labels Dec 28, 2023

vishesh92 mentioned this pull request Dec 28, 2023

Fixup test_list_volumes.py failure #8392

Closed

13 tasks

Filter out volumes in Destroy state before checking the count of volumes

17a1e03

vishesh92 mentioned this pull request Jan 3, 2024

Use join instead of views #8321

Merged

13 tasks

harikrishna-patnala approved these changes Jan 9, 2024

View reviewed changes

yadvr approved these changes Feb 5, 2024

View reviewed changes

vishesh92 changed the base branch from main to 4.19 February 5, 2024 19:00

weizhouapache approved these changes Feb 7, 2024

View reviewed changes

weizhouapache merged commit df412a9 into apache:4.19 Feb 7, 2024

vishesh92 deleted the e2e-test-resource-listing branch February 7, 2024 07:30

yadvr modified the milestones: 4.19.1.0, 4.19.0.0 Mar 14, 2024

Add e2e tests for listing resources #8410

Add e2e tests for listing resources #8410

Uh oh!

Conversation

vishesh92 commented Dec 28, 2023

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

vishesh92 commented Dec 28, 2023

Uh oh!

blueorangutan commented Dec 28, 2023

Uh oh!

codecov bot commented Dec 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Dec 28, 2023

Uh oh!

vishesh92 commented Dec 28, 2023

Uh oh!

blueorangutan commented Dec 28, 2023

Uh oh!

blueorangutan commented Dec 28, 2023

Uh oh!

blueorangutan commented Dec 28, 2023

Uh oh!

vishesh92 commented Jan 3, 2024

Uh oh!

blueorangutan commented Jan 3, 2024

Uh oh!

blueorangutan commented Jan 3, 2024

Uh oh!

vishesh92 commented Jan 3, 2024

Uh oh!

blueorangutan commented Jan 3, 2024

Uh oh!

blueorangutan commented Jan 3, 2024

Uh oh!

blueorangutan commented Jan 4, 2024

Uh oh!

DaanHoogland commented Jan 4, 2024

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Feb 6, 2024

Uh oh!

blueorangutan commented Feb 6, 2024

Uh oh!

blueorangutan commented Feb 6, 2024

Uh oh!

DaanHoogland commented Feb 6, 2024

Uh oh!

blueorangutan commented Feb 6, 2024

Uh oh!

blueorangutan commented Feb 6, 2024

Uh oh!

blueorangutan commented Feb 6, 2024

Uh oh!

vishesh92 commented Feb 7, 2024

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Dec 28, 2023 •

edited

Loading