Remove queries for _all_docs, _design_docs and _local_docs#1143
Merged
iilyak merged 1 commit intoapache:masterfrom Feb 6, 2018
Merged
Remove queries for _all_docs, _design_docs and _local_docs#1143iilyak merged 1 commit intoapache:masterfrom
iilyak merged 1 commit intoapache:masterfrom
Conversation
issue 820
670f350 to
1446e87
Compare
Member
|
Can you describe what the new endpoints are? Other than the new endpoint moving, are you making backwards-incompatible changes to endpoints other than the new one introduced? If so we need to be careful about this landing in 2.x. |
Member
|
As @rnewson just said on IRC, and as I asked above, this should not have landed without discussion. You can't just remove pre-existing features (not the new one that was merged post 2.1.1) without a discussion. We have customers depending on this. Please revert ASAP! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In the #1032, queries are supported to
_all_docs,_design_docsand_local_docsto address the requirement in #820.However, the response schema changes depending on what is POSTed. This makes it quite hard to interact with from static type languages. So we plan to move the implementation to separate endpoint. As the first step, this PR is used to remove queries for _all_docs, _design_docs and _local_docs.
Testing recommendations
make check skip_deps+=couch_epi apps=chttpd tests=all_test_
Related Issues or Pull Requests
#820
#1032
Checklist