test: port large_docs.js to Elixir test suite#1745
Merged
garrensmith merged 2 commits intoapache:masterfrom Nov 28, 2018
Merged
test: port large_docs.js to Elixir test suite#1745garrensmith merged 2 commits intoapache:masterfrom
garrensmith merged 2 commits intoapache:masterfrom
Conversation
3 tasks
Member
|
@dottorblaster Keeping in mind #1767, please re-run @jaydoane are you able to review this contribution as well? Much obliged if you can :) |
dottorblaster
force-pushed
the
port-large-docs-to-elixir
branch
from
0c6e2d9 to
93e2f5e
Compare
Member
Author
|
@wohali rebased and checked, all set. Waiting for review and merge 👍 |
garrensmith
requested changes
Nov 28, 2018
Member
garrensmith
left a comment
garrensmith
left a comment
There was a problem hiding this comment.
1 small change and then I can merge
| This is a port of the large_docs.js suite | ||
| """ | ||
|
|
||
| # Should we use `"X-Couch-Full-Commit":"false"` header here? |
Member
There was a problem hiding this comment.
Judging from what @jaydoane said in another PR I don't think so. So you can remove this commetn as well :)
dottorblaster
force-pushed
the
port-large-docs-to-elixir
branch
from
62ee055 to
f7cf12c
Compare
garrensmith
approved these changes
Nov 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I just ported
large_docs.jsto the Elixir test suite.Testing recommendations
Issue
make elixir😬Related Issues or Pull Requests
None
Checklist