Check code format before running elixir test suite#1767
Merged
wohali merged 5 commits intoapache:masterfrom Nov 28, 2018
Merged
Check code format before running elixir test suite#1767wohali merged 5 commits intoapache:masterfrom
wohali merged 5 commits intoapache:masterfrom
Conversation
Member
|
@van-mronov Since we don't run this in the CI test suite yet, can you paste for me the output of running |
Contributor
Author
|
@wohali for formatted code it just outputs nothing and returns 0 $ cd test/elixir/ && mix format --check-formatted
$ echo $?
0For current master branch (not formatted code): $ cd test/elixir/ && mix format --check-formatted
** (Mix) mix format failed due to --check-formatted.
The following files were not formatted:
* test/replication_test.exs
* test/reduce_test.exs
* test/view_collation_test.exs
* test/test_helper.exs
* test/security_validation_test.exs
* test/uuids_test.exs
* test/rewrite_test.exs
* test/basics_test.exs
* test/lots_of_docs_test.exs
* test/bulk_docs_test.exs
* test/all_docs_test.exs
* test/config_test.exs
* test/conflicts_test.exs
* lib/couch.ex
* test/helper_test.exs
* test/compact_test.exs
* test/batch_save_test.exs
* mix.exs
$ echo $?
1 |
wohali
approved these changes
Nov 28, 2018
|
|
||
| .PHONY: elixir | ||
| elixir: | ||
| elixir: elixir-check-formatted |
Member
There was a problem hiding this comment.
Thank you for updating Makefile.win as well!
Contributor
Author
There was a problem hiding this comment.
No problem, but I have no chance to try it.
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
mix format;Testing recommendations
make elixirRelated Issues or Pull Requests
Issue #1756
PR #1745
PR #1760
Checklist