test: port coffee.js to Elixir test suite

[dottorblaster]

Overview

I just ported coffee.js to the Elixir test suite.

Testing recommendations

Issue make elixir

Related Issues or Pull Requests

None

Checklist

• Code is written and works correctly;
• Changes are covered by tests;
• Documentation reflects the changes;

[jaydoane]

Not sure if we need this header any more. I ran this test with that header removed, and it also passed.

[dottorblaster]

Yeah, I tried with and without the header and it was ~worthless, it seemed to get better but it didn't solve anything. We can drop it out eventually, I agree.

[dottorblaster]

With the new approach, the need for this header became absolute zero. I removed it indeed. Thanks!

[jaydoane]

Using a fixed sleep time is still very fragile (since CI machines can be much slower than your dev env), and I would recommend using a more robust synchronization technique. You could do something like:

  retry_until(fn ->
    %{"rows" => values} =
      Couch.get("/#{db_name}/_design/coffee/_view/myview",
        headers: @headers
      ).body
     assert 5 === hd(values)["value"]  
  end)

[dottorblaster]

I think we would have to discuss about an official way to check collection consistency right after an update 😬 this looks fine, I'll try. Thanks for pointing this out!

[dottorblaster]

@jaydoane I think I came out with a cleverer approach in the end. Since we don't care about that specific execution order and we are testing the coffeescript query language here, now the test plays with documents first, then it receives the design document that builds the index. This way we work around the eventual consistency for the purpose of this test and we don't need any retry_until logic.

Thanks for pointing out that retry_until can be used anyway, I think it'll be useful for future ports! 👍 And thanks for the review man 😎

[wohali]

@dottorblaster Keeping in mind #1767, please re-run make elixir on this PR after rebasing on master and ensure that your new test conforms to the coding standard.

Once I have a +1 from you I'll merge this PR. Thanks!

[dottorblaster]

@wohali done. Thanks!