Add Global timeout for map/reduce queries#1766
Add Global timeout for map/reduce queries#1766garrensmith merged 2 commits intoapache:masterfrom garrensmith:add-partition-timeout
Conversation
|
Looks good but obviously as currently written should wait till after we finish partition queries. |
davisp
left a comment
davisp
left a comment
There was a problem hiding this comment.
Decided there's actually a few necessary tweaks but they're small.
| global_view_timeout(Args) -> | ||
| PartitionQuery = couch_mrview_util:get_extra(Args, partition, false), | ||
| case PartitionQuery of | ||
| false -> timeout("global_view_timeout", "infinity"); |
There was a problem hiding this comment.
You're doubling up the _timeout suffix cause the timeout/2 call appends that as well. Also global_view_timeout should probably be shortened to just view_timeout because you're looking at global vs partitioned. Also global_partition is a bit of a misnomer and should just be partition_view_timeout.
Also I think the SOP is to add commented out config options with their default values in default.ini. If the other timeout config options aren't already present I'd add all five settings in a separate commit on this PR.
There was a problem hiding this comment.
I've removed the global_ part for the names. The reason I added that is that rexi has two timeouts. A timeout for how long to wait for each response from a node and then an overall global timeout for the node to send all responses. The view and partition_view are for the second situation where as the all_docs and request timeouts are fo the individual requests.
garrensmith
changed the base branch from
feature/user-partitioned-databases-davisp
to
feature/database-partitions
|
Whoops. No idea how I managed to close this. Definitely wasn't on purpose. |
| attachments_timeout() -> | ||
| timeout("attachments", "600000"). | ||
|
|
||
| global_view_timeout(Args) -> |
There was a problem hiding this comment.
Still seems odd to be calling this global_view_timeout when it applies to both global and partitioned.
There was a problem hiding this comment.
I've changed the name
davisp
force-pushed
the
feature/database-partitions
branch
10 times, most recently
from
4da3bab to
fc696e8
Compare
davisp
force-pushed
the
feature/database-partitions
branch
11 times, most recently
from
90be3b0 to
6c2785a
Compare
davisp
force-pushed
the
feature/database-partitions
branch
2 times, most recently
from
005b442 to
60bbe3f
Compare
davisp
force-pushed
the
feature/database-partitions
branch
5 times, most recently
from
be1fe52 to
31a4a53
Compare
davisp
force-pushed
the
feature/database-partitions
branch
7 times, most recently
from
04146c3 to
51a482e
Compare
davisp
force-pushed
the
feature/database-partitions
branch
2 times, most recently
from
8cd68be to
91af772
Compare
garrensmith
changed the base branch from
feature/database-partitions
to
master
This makes the global timeout for a map/reduce and all_docs request configurable via the config. It separates the config into global queries and partition queries so that it is possible to make the global timeout is for partitioned queries
|
+1 |
2 participants
Overview
This makes the global timeout for a map/reduce and all_docs request
configurable via the config. It separates the config into global queries
and partition queries so that it is possible to make the global timeout
is for partitioned queries
Testing recommendations
Add the
global_partition_view_timeoutto the[fabric]config. You can then make queries and see if they timeout based on the value set.Checklist