Skip to content

Fabric attachment timeout was defaulting to 10m#4471

Closed
KangTheTerrible wants to merge 1 commit intoapache:mainfrom
KangTheTerrible:patch-1
Closed

Fabric attachment timeout was defaulting to 10m#4471
KangTheTerrible wants to merge 1 commit intoapache:mainfrom
KangTheTerrible:patch-1

Conversation

@KangTheTerrible
Copy link
Copy Markdown
Contributor

Default ini has this value as 1m

Overview

While investigating long open connections for attachments I stumbled on this. Uncertain if this is correct or the default ini value is correct.

Testing recommendations

Related Issues or Pull Requests

Checklist

  • Code is written and works correctly
  • Changes are covered by tests
  • Any new configurable parameters are documented in rel/overlay/etc/default.ini
  • Documentation changes were made in the src/docs folder
  • Documentation changes were backported (separated PR) to affected branches

@big-r81
Copy link
Copy Markdown
Contributor

big-r81 commented Mar 11, 2023

Hi,

thx and good find, looks like a typo! To be safe, I would like to double check this @nickva!

Default ini has this value as 1m
@nickva
Copy link
Copy Markdown
Contributor

nickva commented Mar 11, 2023

I think the 10min is intended ec26cba and the .ini value is wrong.

@big-r81
Copy link
Copy Markdown
Contributor

big-r81 commented Mar 11, 2023

Maybe you are right @nickva . Is this timeout for uploading attachments? In #1766 the timeouts were set in default.ini.

@big-r81
Copy link
Copy Markdown
Contributor

big-r81 commented Mar 15, 2023

Closing this for now, it seems correct, that the attachment timeout is 600000. See #1264 (comment)

@big-r81 big-r81 closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants