Fabric attachment timeout was defaulting to 10m#4471
Closed
KangTheTerrible wants to merge 1 commit intoapache:mainfrom
Closed
Fabric attachment timeout was defaulting to 10m#4471KangTheTerrible wants to merge 1 commit intoapache:mainfrom
KangTheTerrible wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Hi, thx and good find, looks like a typo! To be safe, I would like to double check this @nickva! |
Default ini has this value as 1m
Contributor
|
I think the 10min is intended ec26cba and the .ini value is wrong. |
Contributor
Contributor
|
Closing this for now, it seems correct, that the attachment timeout is 600000. See #1264 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default ini has this value as 1m
Overview
While investigating long open connections for attachments I stumbled on this. Uncertain if this is correct or the default ini value is correct.
Testing recommendations
Related Issues or Pull Requests
Checklist
rel/overlay/etc/default.inisrc/docsfolder