Skip to content

TPC-DS Plan Stability Suites Not Running in CI #2469

@andygrove

Description

@andygrove

Describe the bug

Regression was introduced in #2178

We only run the tests if the scan is auto mode:

  if (CometConf.COMET_NATIVE_SCAN_IMPL.get() == CometConf.SCAN_AUTO) {
    tpcdsQueriesV2_7_0.foreach { q =>
      test(s"check simplified (tpcds-v2.7.0/$q)") {
        testQuery("tpcds-v2.7.0", q)
      }
    }
  }

We use an env var to specify scan type:

    - name: Run all tests
      shell: bash
      if: ${{ inputs.suites == '' }}
      env:
        COMET_PARQUET_SCAN_IMPL: ${{ inputs.scan_impl }}

The PR builds never specify auto:

          - name: "Spark 3.5.5, JDK 17, Scala 2.13"
            java_version: "17"
            maven_opts: "-Pspark-3.5 -Dspark.version=3.5.5 -Pscala-2.13"
            scan_impl: "native_comet"

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions