Skip to content

chore: Update stability suite to use auto scan instead of native_comet#2178

Merged
andygrove merged 2 commits intoapache:mainfrom
andygrove:stability-suite-auto-scan
Aug 27, 2025
Merged

chore: Update stability suite to use auto scan instead of native_comet#2178
andygrove merged 2 commits intoapache:mainfrom
andygrove:stability-suite-auto-scan

Conversation

@andygrove
Copy link
Copy Markdown
Member

@andygrove andygrove commented Aug 17, 2025

Which issue does this PR close?

Part of #2177

Rationale for this change

We should be testing with defaults rather than testing legacy scan.

What changes are included in this PR?

  • The first commit updates the test to use auto instead of native_comet
  • The second commit performs a search and replace for native_comet -> native_iceberg_compat in the golden files

How are these changes tested?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.00%. Comparing base (f09f8af) to head (8f90232).
⚠️ Report is 1161 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2178      +/-   ##
============================================
+ Coverage     56.12%   58.00%   +1.87%     
- Complexity      976     1276     +300     
============================================
  Files           119      143      +24     
  Lines         11743    13254    +1511     
  Branches       2251     2364     +113     
============================================
+ Hits           6591     7688    +1097     
- Misses         4012     4324     +312     
- Partials       1140     1242     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove marked this pull request as ready for review August 18, 2025 15:12
@andygrove andygrove marked this pull request as draft August 25, 2025 20:10
@andygrove andygrove force-pushed the stability-suite-auto-scan branch from 65ffdec to 8f90232 Compare August 26, 2025 15:08
@andygrove andygrove marked this pull request as ready for review August 26, 2025 15:59
@andygrove andygrove merged commit 0cac7d9 into apache:main Aug 27, 2025
94 checks passed
@andygrove andygrove deleted the stability-suite-auto-scan branch August 27, 2025 00:19
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants