Skip to content

chore: Enable more Spark SQL tests#1869

Merged
andygrove merged 16 commits intoapache:mainfrom
andygrove:issue-231
Jun 12, 2025
Merged

chore: Enable more Spark SQL tests#1869
andygrove merged 16 commits intoapache:mainfrom
andygrove:issue-231

Conversation

@andygrove
Copy link
Copy Markdown
Member

@andygrove andygrove commented Jun 10, 2025

Which issue does this PR close?

Closes #231
Partial fix for #1197 (fixes for Spark 3.5.6 only)

Follows on from #1870

Rationale for this change

Enable more tests

What changes are included in this PR?

  • Update 3.4.3 diff. Ignored tests reduced from 46 to 39.
  • Update 3.5.6 diff. Ignored tests reduced from 43 to 35.
  • Update 4.0.0-preview1 diff. Ignored tests reduced from 46 to 45.

How are these changes tested?

@andygrove andygrove changed the title chore: Enable more Spark SQL tests (issue #231) chore: Fix failed Spark SQL tests due to shuffle enabled Jun 10, 2025
@andygrove andygrove changed the title chore: Fix failed Spark SQL tests due to shuffle enabled chore: Enable more Spark SQL tests Jun 10, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (f09f8af) to head (5b756b0).
Report is 253 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1869      +/-   ##
============================================
+ Coverage     56.12%   59.39%   +3.26%     
- Complexity      976     1151     +175     
============================================
  Files           119      130      +11     
  Lines         11743    12661     +918     
  Branches       2251     2375     +124     
============================================
+ Hits           6591     7520     +929     
+ Misses         4012     3930      -82     
- Partials       1140     1211      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove marked this pull request as ready for review June 10, 2025 20:51
@andygrove
Copy link
Copy Markdown
Member Author

CI failure is unrelated: #1871

Copy link
Copy Markdown
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andygrove andygrove merged commit adcfce4 into apache:main Jun 12, 2025
96 of 97 checks passed
@andygrove andygrove deleted the issue-231 branch June 12, 2025 20:23
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix failed Spark SQL tests due to shuffle enabled

3 participants