Skip to content

chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5#1870

Closed
andygrove wants to merge 6 commits intoapache:mainfrom
andygrove:drop-older-35
Closed

chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5#1870
andygrove wants to merge 6 commits intoapache:mainfrom
andygrove:drop-older-35

Conversation

@andygrove
Copy link
Copy Markdown
Member

Which issue does this PR close?

N/A

Rationale for this change

Reduce developer overhead of keeping multiple diff files up-to-date for Spark 3.5 and speed up CI

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.39%. Comparing base (f09f8af) to head (9b395b8).
⚠️ Report is 1165 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1870      +/-   ##
============================================
+ Coverage     56.12%   59.39%   +3.26%     
- Complexity      976     1151     +175     
============================================
  Files           119      130      +11     
  Lines         11743    12661     +918     
  Branches       2251     2375     +124     
============================================
+ Hits           6591     7520     +929     
+ Misses         4012     3930      -82     
- Partials       1140     1211      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove
Copy link
Copy Markdown
Member Author

CI failure is unrelated: #1871

- name: "Spark 3.5, JDK 11, Scala 2.12"
java_version: "17"
maven_opts: "-Pspark-3.5 -Pscala-2.12"
- name: "Spark 3.5.4, JDK 11, Scala 2.12"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove these profiles?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These profiles are testing native_comet with Spark 3.5. My goal with these changes was to continue testing 3.5.4, 3.5.5, and 3.5.6 without adding any additional jobs.

@andygrove
Copy link
Copy Markdown
Member Author

These changes already got merged in #1869

@andygrove andygrove closed this Jun 12, 2025
@andygrove andygrove deleted the drop-older-35 branch June 12, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants