Skip to content

chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5 #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andygrove wants to merge 6 commits into from
Closed

chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5 #1870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a72fa7
Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5
andygrove Jun 10, 2025
b620ab8
update docs
andygrove Jun 10, 2025
0389705
improve
andygrove Jun 11, 2025
b79ac1b
fix
andygrove Jun 11, 2025
9529241
Merge remote-tracking branch 'apache/main' into drop-older-35
andygrove Jun 11, 2025
9b395b8
revert
andygrove Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/pr_build_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ jobs:
maven_opts: "-Pspark-3.4 -Pscala-2.12"
scan_impl: "native_comet"

- name: "Spark 3.5, JDK 11, Scala 2.12"
java_version: "17"
maven_opts: "-Pspark-3.5 -Pscala-2.12"
- name: "Spark 3.5.4, JDK 11, Scala 2.12"
Copy link
Copy Markdown
Contributor

@parthchandra parthchandra Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove these profiles?

Copy link
Copy Markdown
Member Author

@andygrove andygrove Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These profiles are testing native_comet with Spark 3.5. My goal with these changes was to continue testing 3.5.4, 3.5.5, and 3.5.6 without adding any additional jobs.

java_version: "11"
maven_opts: "-Pspark-3.5 -Dspark.version=3.5.4 -Pscala-2.12"
scan_impl: "native_comet"

- name: "Spark 3.5, JDK 17, Scala 2.13"
- name: "Spark 3.5.5, JDK 17, Scala 2.13"
java_version: "17"
maven_opts: "-Pspark-3.5 -Pscala-2.13"
maven_opts: "-Pspark-3.5 -Dspark.version=3.5.5 -Pscala-2.13"
scan_impl: "native_comet"

- name: "Spark 3.5, JDK 17, Scala 2.12 native_datafusion"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/spark_sql_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
matrix:
os: [ubuntu-24.04]
java-version: [11]
spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full: '3.5.4'}, {short: '3.5', full: '3.5.5'}, {short: '3.5', full: '3.5.6'}]
spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full: '3.5.6'}]
module:
- {name: "catalyst", args1: "catalyst/test", args2: ""}
- {name: "sql/core-1", args1: "", args2: sql/testOnly * -- -l org.apache.spark.tags.ExtendedSQLTest -l org.apache.spark.tags.SlowSQLTest}
Expand Down
Loading
Loading