Skip to content

fix: Remove unreachable code in CometScanRule#2252

Merged
mbutrovich merged 1 commit intoapache:mainfrom
andygrove:remove-unreachable-code-2
Aug 28, 2025
Merged

fix: Remove unreachable code in CometScanRule#2252
mbutrovich merged 1 commit intoapache:mainfrom
andygrove:remove-unreachable-code-2

Conversation

@andygrove
Copy link
Copy Markdown
Member

@andygrove andygrove commented Aug 27, 2025

Which issue does this PR close?

N/A

Rationale for this change

Fix this compiler warning (introduced in #1975):

CometScanRule.scala:327: unreachable code due to variable pattern 'dt' on line 310

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.92%. Comparing base (f09f8af) to head (14998bb).
⚠️ Report is 1154 commits behind head on main.

Files with missing lines Patch % Lines
...n/scala/org/apache/comet/rules/CometScanRule.scala 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2252      +/-   ##
============================================
+ Coverage     56.12%   57.92%   +1.79%     
- Complexity      976     1290     +314     
============================================
  Files           119      143      +24     
  Lines         11743    13336    +1593     
  Branches       2251     2385     +134     
============================================
+ Hits           6591     7725    +1134     
- Misses         4012     4356     +344     
- Partials       1140     1255     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove marked this pull request as ready for review August 28, 2025 00:27
Copy link
Copy Markdown
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove we probably should enable fatal warning for scala.

@comphead
Copy link
Copy Markdown
Contributor

Filed #2254

@mbutrovich mbutrovich merged commit be1f34a into apache:main Aug 28, 2025
95 checks passed
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants