Skip to content

fix: Remove unreachable code in CometScanRule #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbutrovich merged 1 commit into from
Aug 28, 2025
Merged

fix: Remove unreachable code in CometScanRule #2252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,7 @@ case class CometScanRule(session: SparkSession) extends Rule[SparkPlan] with Com
// maps containing complex types are not supported
isComplexType(m.keyType) || isComplexType(m.valueType) ||
hasUnsupportedType(m.keyType) || hasUnsupportedType(m.valueType)
case dt => isStringCollationType(dt)
case _: StringType =>
// we only support `case object StringType` and not other instances of `class StringType`
dataType != StringType
case dt if isStringCollationType(dt) => true
case _ => false
}
}
Expand Down
Loading