chore: Support Spark 4.0.1 instead of 4.0.0#2414
Merged
mbutrovich merged 2 commits intoapache:mainfrom Sep 18, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2414 +/- ##
============================================
+ Coverage 56.12% 57.53% +1.40%
- Complexity 976 1295 +319
============================================
Files 119 147 +28
Lines 11743 13477 +1734
Branches 2251 2354 +103
============================================
+ Hits 6591 7754 +1163
- Misses 4012 4457 +445
- Partials 1140 1266 +126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbutrovich
approved these changes
Sep 18, 2025
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Rationale for this change
TPC-H q1 takes almost 3 minutes when using Comet with Spark 4.0.0, but only takes 10 sceonds when using Spark 4.0.1.
Does it generate a different plan or something?
Thanks @andygrove!
Closed
andygrove
added a commit
to andygrove/datafusion-comet
that referenced
this pull request
Sep 29, 2025
andygrove
added a commit
that referenced
this pull request
Sep 30, 2025
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2345
Rationale for this change
TPC-H q1 takes almost 3 minutes when using Comet with Spark 4.0.0, but only takes 10 sceonds when using Spark 4.0.1.
What changes are included in this PR?
How are these changes tested?