chore: [branch-0.10] Support Spark 4.0.1 instead of 4.0.0 (#2414)#2497
Merged
andygrove merged 2 commits intoapache:branch-0.10from Sep 30, 2025
Merged
chore: [branch-0.10] Support Spark 4.0.1 instead of 4.0.0 (#2414)#2497andygrove merged 2 commits intoapache:branch-0.10from
andygrove merged 2 commits intoapache:branch-0.10from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## branch-0.10 #2497 +/- ##
==============================================
Coverage ? 57.60%
Complexity ? 1296
==============================================
Files ? 147
Lines ? 13507
Branches ? 2391
==============================================
Hits ? 7781
Misses ? 4457
Partials ? 1269 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
parthchandra
approved these changes
Sep 29, 2025
|
|
||
| // Check if there's opportunity to directly copy bytes using `memcpy`. | ||
| if (offset + i) % 8 == 0 && i < num_bits_to_read { | ||
| if (offset + i).is_multiple_of(8) && i < num_bits_to_read { |
Contributor
There was a problem hiding this comment.
Seems unrelated, though not wrong :)
Member
Author
There was a problem hiding this comment.
yes, clippy fixes were needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2423
Backport #2414 to branch-0.10
Rationale for this change
What changes are included in this PR?
How are these changes tested?