Skip to content

feat: Support Count(Distinct) and similar aggregation functions#42

Merged
sunchao merged 1 commit intoapache:mainfrom
huaxingao:distinct
Feb 20, 2024
Merged

feat: Support Count(Distinct) and similar aggregation functions#42
sunchao merged 1 commit intoapache:mainfrom
huaxingao:distinct

Conversation

@huaxingao
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #38.

Rationale for this change

This PR adds the support for COUNT(DISTINCT) and similar aggregation functions.
e.g.

COUNT(DISTINCT col)
SUM(DISTINCT col)
DISTINCT(col)

What changes are included in this PR?

This PR has the changes for DISTINCT aggregation functions

How are these changes tested?

new tests

@sunchao sunchao changed the title Support Count(Distinct) and similar aggregation functions feat: Support Count(Distinct) and similar aggregation functions Feb 19, 2024
@sunchao
Copy link
Copy Markdown
Member

sunchao commented Feb 20, 2024

@huaxingao could you rebase this PR and trigger the CI again?

Copy link
Copy Markdown
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunchao sunchao merged commit 2820327 into apache:main Feb 20, 2024
@sunchao
Copy link
Copy Markdown
Member

sunchao commented Feb 20, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Count(Distinct) (and similar) aggregation

2 participants