test: Ensure traversed operators during finding first partial aggregaion are all native#58
Merged
viirya merged 1 commit intoapache:mainfrom Feb 20, 2024
Merged
Conversation
…tion are all native
Member
Author
|
Merged. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Running TPCH17 query fails now with columnar shuffle + native execution configs:
It is because when we try to find aggregation function inputs for
Finalaggregation, we may get wrong inputs from unrelatedCometHashAggregateExec. When collecting thePartialCometHashAggregateExec, we should ensure we don't cross between native and Spark operators.The internal patch of this PR is originally a bug fix to HashAggregate. Above is its description.
But the just merged patch #42 which is actually a later patch internally and when it is ported it doesn't only copy original commit but latest code. So this fix is also ported in #42 together.
But there is one test added with the internal PR, and it is missed. This patch adds it to Comet.
What changes are included in this PR?
How are these changes tested?