Docs: add examples for RuntimeEnv::register_object_store, improve error messages
#10617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you @aditanase -- this is great 🙏 . I started the CI Also I made another PR to try and improve the documentation about |
alamb
changed the title
RuntimeEnv::register_object_store, improve error messages
alamb
reviewed
May 22, 2024
| /// | ||
| /// Or how to set up a http object store: | ||
| /// ``` | ||
| /// let base_url = Url::parse("https://github.com").unwrap(); |
Contributor
There was a problem hiding this comment.
These examples are run automatically via cargo test --doc -- so they need to be completely standlone
I took the liberty of pushing a commit to this PR that did so
Contributor
Author
There was a problem hiding this comment.
Thanks so much for making these pass, I'll remember to run the doc tests next time, only looked at the doc site before submitting the PR.
alamb
approved these changes
May 22, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks again @aditanase -- really apprecaited
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…rror messages (apache#10617) * Docs: add examples for RuntimeEnv::register_object_store * adjust example --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10616. Documentation only