Add SessionContext::register_object_store #10621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 22, 2024
datafusion-cli/src/catalog.rs
Outdated
| ) | ||
| .await?; | ||
| state.runtime_env().register_object_store(url, store); | ||
| state.register_object_store(url, store); |
Contributor
Author
There was a problem hiding this comment.
the point of this PR is to avoid having to do runtime_env()
alamb
force-pushed
the
alamb/register_on_session_Context
branch
from
a66f38a to
12f31a3
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10616
Rationale for this change
Inspired by @aditanase in #10617 and my own experience in #10549 I wanted to make it easier to find / discover how to register new object stores
What changes are included in this PR?
SessionContext::register_object_storeAre these changes tested?
Are there any user-facing changes?