Minor: Add error tests for min/max with 2 arguments#12024
Merged
Dandandan merged 1 commit intoapache:mainfrom Aug 16, 2024
Merged
Minor: Add error tests for min/max with 2 arguments#12024Dandandan merged 1 commit intoapache:mainfrom
Dandandan merged 1 commit intoapache:mainfrom
Conversation
alamb
commented
Aug 15, 2024
| ---- | ||
| 0 1 | ||
|
|
||
| query error min/max was called with 2 arguments. It requires only 1. |
Contributor
Author
There was a problem hiding this comment.
Prior to #12016 this fails with an assert:
Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-baf44314cb754c4d)
Running "aggregate_skip_partial.slt"
Running "aggregate.slt"
Running "aggregates_topk.slt"
thread 'tokio-runtime-worker' panicked at datafusion/functions-aggregate/src/min_max.rs:71:5:
assertion `left == right` failed
left: 2
right: 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
External error: task 18 panicked
Error: Execution("1 failures")
Dandandan
approved these changes
Aug 16, 2024
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #12011
Rationale for this change
Add test for check in #12016
What changes are included in this PR?
Add slttest
Are these changes tested?
All tests
Are there any user-facing changes?