Skip to content

Minor: Add error tests for min/max with 2 arguments #12024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dandandan merged 1 commit into from
Aug 16, 2024
Merged

Minor: Add error tests for min/max with 2 arguments #12024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions datafusion/sqllogictest/test_files/aggregate.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1881,6 +1881,12 @@ SELECT MIN(c1), MIN(c2) FROM test
----
0 1

query error min/max was called with 2 arguments. It requires only 1.
Copy link
Copy Markdown
Contributor Author

@alamb alamb Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to #12016 this fails with an assert:

     Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-baf44314cb754c4d)
Running "aggregate_skip_partial.slt"
Running "aggregate.slt"
Running "aggregates_topk.slt"
thread 'tokio-runtime-worker' panicked at datafusion/functions-aggregate/src/min_max.rs:71:5:
assertion `left == right` failed
  left: 2
 right: 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
External error: task 18 panicked
Error: Execution("1 failures")

SELECT MIN(c1, c2) FROM test

query error min/max was called with 2 arguments. It requires only 1.
SELECT MAX(c1, c2) FROM test

# aggregate_grouped
query II
SELECT c1, SUM(c2) FROM test GROUP BY c1 order by c1
Expand Down