feat(unparser): adding alias for table scan filter in sql unparser #12453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitriibugakov
approved these changes
Sep 13, 2024
goldmedal
approved these changes
Sep 13, 2024
Contributor
goldmedal
left a comment
goldmedal
left a comment
There was a problem hiding this comment.
Thanks @Lordworms working on this. Overall looks good to me. Just leave some suggestions.
Comment on lines
699
to
703
| fn test_alias_pushdown() -> Result<()> { | ||
| let schema = Schema::new(vec![ | ||
| Field::new("id", DataType::Int64, false), | ||
| Field::new("age", DataType::Int64, false), | ||
| ]); |
Contributor
There was a problem hiding this comment.
I'm not sure if adding the unparsing test here is appropriate. 🤔 Typically, we add unparse-related tests in datafusion/sql/tests/cases/plan_to_sql.rs
I left a disabled test for this issue in the previous PR #12158. I guess we can just enable it and remove this test.
datafusion/sql/src/unparser/plan.rs
Outdated
Comment on lines
601
to
605
| .reduce(|acc, expr_result| match (acc, expr_result) { | ||
| (Ok(acc_expr), Ok(expr)) => Ok(acc_expr.and(expr)), | ||
| (Err(e), _) | (_, Err(e)) => Err(e), | ||
| }) |
Contributor
There was a problem hiding this comment.
We can simplify here like this
Suggested change
| .reduce(|acc, expr_result| match (acc, expr_result) { | |
| (Ok(acc_expr), Ok(expr)) => Ok(acc_expr.and(expr)), | |
| (Err(e), _) | (_, Err(e)) => Err(e), | |
| }) | |
| .reduce(|acc, expr_result| { | |
| acc.and_then(|acc_expr| { | |
| expr_result.map(|expr| acc_expr.and(expr)) | |
| }) | |
| }) |
Contributor
|
I think @goldmedal 's comments are all great. Once those have been addressed this PR will be ready to go from my persective. Thank you @Lordworms @goldmedal and @dmitrybugakov |
alamb
changed the title
Lordworms
force-pushed
the
issue_12368
branch
from
3a63ca0 to
d744393
Compare
Contributor
Author
|
@goldmedal @alamb @dmitrybugakov Thanks for the review! |
alamb
changed the title
alamb
approved these changes
Sep 15, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks -- looks good to me
sgrebnov
pushed a commit
to spiceai/datafusion
that referenced
this pull request
Oct 23, 2024
sgrebnov
added a commit
to spiceai/datafusion
that referenced
this pull request
Oct 24, 2024
* init (apache#12453) * Fix unparse table scan with the projection pushdown (apache#12534) * unparse the projection base on the source schema * refactor and enhance the test * Fix unparsing OFFSET (apache#12539) * Unparse Sort with pushdown limit to SQL string (apache#12873) * unparse Sort with push down limit * cargo fmt * set query limit directly * Unparse `SubqueryAlias` without projections to SQL (apache#12896) * change pub function comment to doc * unparse subquery alias without projections * fix tests * rollback the empty line * rollback the empty line * exclude the table_scan with pushdown case * fmt and clippy * simplify the ast to string and remove unused debug code * enhance unparsing plan with pushdown to avoid unnamed subquery (apache#13006) * Update --------- Co-authored-by: Lordworms <48054792+Lordworms@users.noreply.github.com> Co-authored-by: Jax Liu <liugs963@gmail.com> Co-authored-by: Justus Flerlage <justus@sutsuj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12368
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?