-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix unparse table scan with the projection pushdown #12534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI @phillipleblanc and @sgrebnov , do you possibly have time to review this PR? |
|
@goldmedal , @alamb - the change looks good, thank you! |
phillipleblanc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching and fixing this.
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @goldmedal and for the reviews @phillipleblanc and @sgrebnov 🚀
We can keep the code moving fast with distributed review 🚋
|
Thanks @alamb @sgrebnov @phillipleblanc for the review 👍 |
* unparse the projection base on the source schema * refactor and enhance the test
* init (apache#12453) * Fix unparse table scan with the projection pushdown (apache#12534) * unparse the projection base on the source schema * refactor and enhance the test * Fix unparsing OFFSET (apache#12539) * Unparse Sort with pushdown limit to SQL string (apache#12873) * unparse Sort with push down limit * cargo fmt * set query limit directly * Unparse `SubqueryAlias` without projections to SQL (apache#12896) * change pub function comment to doc * unparse subquery alias without projections * fix tests * rollback the empty line * rollback the empty line * exclude the table_scan with pushdown case * fmt and clippy * simplify the ast to string and remove unused debug code * enhance unparsing plan with pushdown to avoid unnamed subquery (apache#13006) * Update --------- Co-authored-by: Lordworms <48054792+Lordworms@users.noreply.github.com> Co-authored-by: Jax Liu <liugs963@gmail.com> Co-authored-by: Justus Flerlage <justus@sutsuj.com>
Which issue does this PR close?
no corresponding issue.
Rationale for this change
The projection indices of a TableScan are the index number of its source schema. I used the
projected_schemathat is the output schema of the table scan in the previous PR. Some cases like the following one will fail because the index is out of the bound.What changes are included in this PR?
projected_schema.Are these changes tested?
yes
Are there any user-facing changes?
no