Optimize performance of math::trunc (~2.5x faster)
#12909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonvandel
reviewed
Oct 13, 2024
| let num_array = num.as_primitive::<Float32Type>(); | ||
| let precision_array = precision.as_primitive::<Int64Type>(); | ||
| let result: PrimitiveArray<Float32Type> = | ||
| arrow_arith::arity::binary(num_array, precision_array, |x, y| { |
Contributor
There was a problem hiding this comment.
Is this the same function as this? https://docs.rs/arrow/latest/arrow/compute/fn.binary.html
If so you could remove the new dependency (although it is in the dependency closure anyway already)
Contributor
Author
There was a problem hiding this comment.
@simonvandel Thanks so much for reviewing
Is this the same function as this? https://docs.rs/arrow/latest/arrow/compute/fn.binary.html
Oh, yes it is. Nice!
Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com>
tlm365
force-pushed
the
optimize-trunc
branch
from
27c8635 to
7e6f820
Compare
tlm365
changed the title
math::trunc (~2.5x faster)
alamb
approved these changes
Oct 15, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @tlm365 and @simonvandel
findepi
reviewed
Oct 15, 2024
| ColumnarValue::Scalar(Int64(Some(0))) => Ok(Arc::new( | ||
| make_function_scalar_inputs!(num, "num", Float64Array, { f64::trunc }), | ||
| ) as ArrayRef), | ||
| ColumnarValue::Array(precision) => Ok(Arc::new(make_function_inputs2!( |
Contributor
|
I merged up from main to resolve a conflict on this branch |
Contributor
|
🚀 thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Same idea as #12881. Using the
unary/binaryfunctions allow faster processing (most likely auto-vectorized code) by avoiding branching on nulls.What changes are included in this PR?
unaryandbinaryAre these changes tested?
Existing testcases.
Are there any user-facing changes?
No.
**BENCHMARK RESULT
