Implement get_possible_types for Uniform, Coercible, Variadic, Numeric and String #13313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FYI @goldmedal |
goldmedal
reviewed
Nov 9, 2024
Contributor
goldmedal
left a comment
goldmedal
left a comment
There was a problem hiding this comment.
Thanks @delamarch3 for working on this. Overall looks good to me but some suggestions.
Co-authored-by: Jax Liu <liugs963@gmail.com>
Contributor
Author
|
@goldmedal Thanks for the review, I've committed your suggestions |
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
Nov 12, 2024
…c and String (apache#13313) * implement get_possible_types for Uniform, Coercible, Variadic, Numeric and String * fix possible types for variadic * use cloned * add Utf8View to STRINGS * add todo to support other native types Co-authored-by: Jax Liu <liugs963@gmail.com> --------- Co-authored-by: Jax Liu <liugs963@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13271
Rationale for this change
As mentioned on the issue, the implementations for
information_schema.routinesandinformation_schema.parameterswill need to be able to list all possible combinations of argument types.What changes are included in this PR?
Uniform,Coercible,Variadic,NumericandString.Are these changes tested?
Yes
Are there any user-facing changes?
No