Skip to content

Implement get_possible_types for Uniform, Coercible, Variadic, Numeric and String #13313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goldmedal merged 5 commits into from
Nov 10, 2024
Merged

Implement get_possible_types for Uniform, Coercible, Variadic, Numeric and String #13313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d563551
implement get_possible_types for Uniform, Coercible, Variadic, Numeri…
velaskuez Nov 8, 2024
040492c
fix possible types for variadic
velaskuez Nov 9, 2024
f2fbc1f
use cloned
velaskuez Nov 9, 2024
a1b376f
add Utf8View to STRINGS
velaskuez Nov 9, 2024
b78db50
add todo to support other native types
velaskuez Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 121 additions & 8 deletions datafusion/expr-common/src/signature.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@
//! Signature module contains foundational types that are used to represent signatures, types,
//! and return types of functions in DataFusion.

use crate::type_coercion::aggregates::{NUMERICS, STRINGS};
use arrow::datatypes::DataType;
use datafusion_common::types::LogicalTypeRef;
use datafusion_common::types::{LogicalTypeRef, NativeType};
use itertools::Itertools;

/// Constant that is used as a placeholder for any valid timezone.
/// This is used where a function can accept a timestamp type with any
Expand Down Expand Up @@ -258,17 +260,66 @@ impl TypeSignature {
.iter()
.flat_map(|type_sig| type_sig.get_possible_types())
.collect(),
TypeSignature::Uniform(arg_count, types) => types
.iter()
.cloned()
.map(|data_type| vec![data_type; *arg_count])
.collect(),
TypeSignature::Coercible(types) => types
.iter()
.map(|logical_type| get_data_types(logical_type.native()))
.multi_cartesian_product()
.collect(),
TypeSignature::Variadic(types) => types
.iter()
.cloned()
.map(|data_type| vec![data_type])
.collect(),
TypeSignature::Numeric(arg_count) => NUMERICS
.iter()
.cloned()
.map(|numeric_type| vec![numeric_type; *arg_count])
.collect(),
TypeSignature::String(arg_count) => STRINGS
.iter()
.cloned()
.map(|string_type| vec![string_type; *arg_count])
.collect(),
// TODO: Implement for other types
TypeSignature::Uniform(_, _)
| TypeSignature::Coercible(_)
| TypeSignature::Any(_)
| TypeSignature::Variadic(_)
TypeSignature::Any(_)
| TypeSignature::VariadicAny
| TypeSignature::UserDefined
| TypeSignature::ArraySignature(_)
| TypeSignature::Numeric(_)
| TypeSignature::String(_) => vec![],
| TypeSignature::UserDefined => vec![],
}
}
}

fn get_data_types(native_type: &NativeType) -> Vec<DataType> {
match native_type {
NativeType::Null => vec![DataType::Null],
NativeType::Boolean => vec![DataType::Boolean],
NativeType::Int8 => vec![DataType::Int8],
NativeType::Int16 => vec![DataType::Int16],
NativeType::Int32 => vec![DataType::Int32],
NativeType::Int64 => vec![DataType::Int64],
NativeType::UInt8 => vec![DataType::UInt8],
NativeType::UInt16 => vec![DataType::UInt16],
NativeType::UInt32 => vec![DataType::UInt32],
NativeType::UInt64 => vec![DataType::UInt64],
NativeType::Float16 => vec![DataType::Float16],
NativeType::Float32 => vec![DataType::Float32],
NativeType::Float64 => vec![DataType::Float64],
NativeType::Date => vec![DataType::Date32, DataType::Date64],
NativeType::Binary => vec![
DataType::Binary,
DataType::LargeBinary,
DataType::BinaryView,
],
NativeType::String => {
vec![DataType::Utf8, DataType::LargeUtf8, DataType::Utf8View]
}
// TODO: support other native types
_ => vec![],
}
}

Expand Down Expand Up @@ -417,6 +468,8 @@ impl Signature {

#[cfg(test)]
mod tests {
use datafusion_common::types::{logical_int64, logical_string};

use super::*;

#[test]
Expand Down Expand Up @@ -515,5 +568,65 @@ mod tests {
vec![DataType::Utf8]
]
);

let type_signature =
TypeSignature::Uniform(2, vec![DataType::Float32, DataType::Int64]);
let possible_types = type_signature.get_possible_types();
assert_eq!(
possible_types,
vec![
vec![DataType::Float32, DataType::Float32],
vec![DataType::Int64, DataType::Int64]
]
);

let type_signature =
TypeSignature::Coercible(vec![logical_string(), logical_int64()]);
let possible_types = type_signature.get_possible_types();
assert_eq!(
possible_types,
vec![
vec![DataType::Utf8, DataType::Int64],
vec![DataType::LargeUtf8, DataType::Int64],
vec![DataType::Utf8View, DataType::Int64]
]
);

let type_signature =
TypeSignature::Variadic(vec![DataType::Int32, DataType::Int64]);
let possible_types = type_signature.get_possible_types();
assert_eq!(
possible_types,
vec![vec![DataType::Int32], vec![DataType::Int64]]
);

let type_signature = TypeSignature::Numeric(2);
let possible_types = type_signature.get_possible_types();
assert_eq!(
possible_types,
vec![
vec![DataType::Int8, DataType::Int8],
vec![DataType::Int16, DataType::Int16],
vec![DataType::Int32, DataType::Int32],
vec![DataType::Int64, DataType::Int64],
vec![DataType::UInt8, DataType::UInt8],
vec![DataType::UInt16, DataType::UInt16],
vec![DataType::UInt32, DataType::UInt32],
vec![DataType::UInt64, DataType::UInt64],
vec![DataType::Float32, DataType::Float32],
vec![DataType::Float64, DataType::Float64]
]
);

let type_signature = TypeSignature::String(2);
let possible_types = type_signature.get_possible_types();
assert_eq!(
possible_types,
vec![
vec![DataType::Utf8, DataType::Utf8],
vec![DataType::LargeUtf8, DataType::LargeUtf8],
vec![DataType::Utf8View, DataType::Utf8View]
]
);
}
}
3 changes: 2 additions & 1 deletion datafusion/expr-common/src/type_coercion/aggregates.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ use arrow::datatypes::{

use datafusion_common::{internal_err, plan_err, Result};

pub static STRINGS: &[DataType] = &[DataType::Utf8, DataType::LargeUtf8];
pub static STRINGS: &[DataType] =
&[DataType::Utf8, DataType::LargeUtf8, DataType::Utf8View];

pub static SIGNED_INTEGERS: &[DataType] = &[
DataType::Int8,
Expand Down