Fill missing methods in aliased UDF impls #17080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aliased UDF impls -- `AliasedScalarUDFImpl`, `AliasedAggregateUDFImpl` and `AliasedWindowUDFImpl` are supposed to forward all methods (except `aliases` to the underlying implementation. However, they failed to do so, with many optional methods not being forwarded. This change fixes this for good. Adds the missing method implementations. Replaces a code comment with compile-time check that all methods are indeed implemented.
findepi
force-pushed
the
findepi/fill-missing-methods-in-aliased-udf-impls-971c00
branch
from
96a8a6e to
a03ca3f
Compare
alamb
approved these changes
Aug 8, 2025
| } | ||
| } | ||
|
|
||
| #[warn(clippy::missing_trait_methods)] // Delegates, so it should implement every single trait method |
Contributor
There was a problem hiding this comment.
❤️
TIL missing_trait_methods 👍
findepi
deleted the
findepi/fill-missing-methods-in-aliased-udf-impls-971c00
branch
shruti2522
pushed a commit
to shruti2522/datafusion
that referenced
this pull request
Aug 10, 2025
The aliased UDF impls -- `AliasedScalarUDFImpl`, `AliasedAggregateUDFImpl` and `AliasedWindowUDFImpl` are supposed to forward all methods (except `aliases` to the underlying implementation. However, they failed to do so, with many optional methods not being forwarded. This change fixes this for good. Adds the missing method implementations. Replaces a code comment with compile-time check that all methods are indeed implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aliased UDF impls --
AliasedScalarUDFImpl,AliasedAggregateUDFImplandAliasedWindowUDFImplare supposed to forward all methods (exceptaliasesto the underlying implementation. However, they failed to do so, with many optional methods not being forwarded.This change fixes this for good. Adds the missing method implementations. Replaces a code comment with compile-time check that all methods are indeed implemented.