Skip to content

Conversation

@liukun4515
Copy link
Contributor

Which issue does this PR close?

part of #1619

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added datafusion sql SQL Planner labels Feb 23, 2022
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to support unsigned integer types as well?

@houqp houqp added the enhancement New feature or request label Feb 24, 2022
@liukun4515
Copy link
Contributor Author

LGTM. Do we need to support unsigned integer types as well?

Yes, the unsigned integer will be supported but not now.
From the reference of some database, such as PG and spark, there is no cases for bitwise operation of unsigned integer.
I can't get some use cases to infer the rule of coercion when we meet i32 | u32 and other cases.
@houqp

@alamb
Copy link
Contributor

alamb commented Mar 1, 2022

@liukun4515 this PR has some conflicts now -- any chance you have a few moments to resolve them so we can get it merged? If not, I will attempt to do so later in the week.

@liukun4515
Copy link
Contributor Author

this PR has some conflicts now -- any chance you have a few moments to resolve them so we can get it merged? If not, I will attempt to do so later in the week.

I will resolve the conflicts tomorrow.

@liukun4515
Copy link
Contributor Author

It's ready to be merged.

@alamb alamb merged commit 3261e2b into apache:master Mar 4, 2022
@alamb
Copy link
Contributor

alamb commented Mar 4, 2022

Thanks @liukun4515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants