Skip to content

Conversation

@askoa
Copy link
Contributor

@askoa askoa commented Sep 10, 2022

Which issue does this PR close?

Closes #3420

Are there any user-facing changes?

I think inclusion of bitwise XOR is a user-facing change.

Not sure if any documentation change is required. I mimicked a similar PR #1876. If any documentation update is required, then reviewers can point me to the documentation changes required.

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sql SQL Planner labels Sep 10, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @askoa -- this is a great first contribution

In terms of documentation it seems we are missing all the bitwise operators in https://github.com/apache/arrow-datafusion/blob/master/docs/source/user-guide/expressions.md

perhaps you could it (it would be fine to do as a follow on PR)

Operator::BitwiseXor,
Int64Array,
DataType::Int64,
vec![9i64, 4i64, 6i64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@askoa
Copy link
Contributor Author

askoa commented Sep 10, 2022

perhaps you could it (it would be fine to do as a follow on PR)

I created a issue to track this. I will update the documents.

@alamb alamb changed the title Include bitwise xor operator Implement bitwise XOR operator (#) Sep 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Merging #3430 (6b4da9a) into master (e14d090) will decrease coverage by 0.00%.
The diff coverage is 69.69%.

@@            Coverage Diff             @@
##           master    #3430      +/-   ##
==========================================
- Coverage   85.63%   85.62%   -0.01%     
==========================================
  Files         296      296              
  Lines       54469    54501      +32     
==========================================
+ Hits        46642    46665      +23     
- Misses       7827     7836       +9     
Impacted Files Coverage Δ
datafusion/expr/src/binary_rule.rs 84.50% <ø> (ø)
datafusion/expr/src/operator.rs 95.31% <0.00%> (-1.52%) ⬇️
datafusion/sql/src/planner.rs 80.88% <0.00%> (-0.04%) ⬇️
...on/physical-expr/src/expressions/binary/kernels.rs 52.33% <53.33%> (+0.16%) ⬆️
datafusion/physical-expr/src/expressions/binary.rs 97.63% <93.75%> (-0.08%) ⬇️
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/common/src/scalar.rs 84.99% <0.00%> (-0.07%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.52% <0.00%> (+0.33%) ⬆️
datafusion/core/src/physical_plan/metrics/value.rs 87.43% <0.00%> (+0.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alamb alamb merged commit 8df5496 into apache:master Sep 11, 2022
@alamb
Copy link
Contributor

alamb commented Sep 11, 2022

Thanks again @askoa

@ursabot
Copy link

ursabot commented Sep 11, 2022

Benchmark runs are scheduled for baseline = deea8c3 and contender = 8df5496. 8df5496 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support bitwise XOR operator (#)

5 participants