Make test_display_pg_json pass regardless of build setup and dependencies#21502
Merged
Jefffrey merged 3 commits intoapache:mainfrom Apr 18, 2026
Merged
Make test_display_pg_json pass regardless of build setup and dependencies#21502Jefffrey merged 3 commits intoapache:mainfrom
test_display_pg_json pass regardless of build setup and dependencies#21502Jefffrey merged 3 commits intoapache:mainfrom
Conversation
AdamGS
changed the title
test_display_pg_json pass regardless of build setup and dependencies
AdamGS
force-pushed
the
adamg/fix-pg-viz-test
branch
from
5615771 to
dd68f71
Compare
Contributor
Author
|
Just realized that there's a SLT test that has the same question in |
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
Jefffrey
approved these changes
Apr 17, 2026
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Makes sense to me. I think I'm hitting a similar issue with a vanilla cargo test where cli_explain_environment_overrides in datafusion-cli fails 🤔
Contributor
|
Thanks @AdamGS |
Rich-T-kid
pushed a commit
to Rich-T-kid/datafusion
that referenced
this pull request
Apr 21, 2026
…encies (apache#21502) ## Which issue does this PR close? - Closes #apache#21501. ## Rationale for this change Running tests for `datafusion-expr` currently fails locally, but due to feature unification with the `subtrait` dependency it does pass in CI. ## What changes are included in this PR? Enables a feature for a dependency during tests. ## Are these changes tested? Ran tests for the crate directly. ## Are there any user-facing changes? None. --------- Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Apr 21, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> One test case in `datafusion-cli` crate is failing locally if you run all tests through `cargo nextest run`, but passes for `cargo test` ``` FAIL [ 0.375s] datafusion-cli::cli_integration cli_explain_environment_overrides ``` The reason is `nextest` triggers a different build graph, which enforces a feature flag in `serde_json` dependency. This PR enforces this feature in the `dev-dependencies` in `datafusion-cli` crate, so the test become deterministic under different test setup. apache#21502 Fixed a similar issue, and also explains why not enabling it in the global dependencies inside `Cargo.toml` ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
test_display_pg_jsoncurrently fails with default features #21501.Rationale for this change
Running tests for
datafusion-exprcurrently fails locally, but due to feature unification with thesubtraitdependency it does pass in CI.What changes are included in this PR?
Enables a feature for a dependency during tests.
Are these changes tested?
Ran tests for the crate directly.
Are there any user-facing changes?
None.