Skip to content

fix: Fix local datafusion-cli test failure#21761

Merged
Dandandan merged 2 commits intoapache:mainfrom
2010YOUY01:fix-local-test
Apr 21, 2026
Merged

fix: Fix local datafusion-cli test failure#21761
Dandandan merged 2 commits intoapache:mainfrom
2010YOUY01:fix-local-test

Conversation

@2010YOUY01
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

One test case in datafusion-cli crate is failing locally if you run all tests through cargo nextest run, but passes for cargo test

        FAIL [   0.375s] datafusion-cli::cli_integration cli_explain_environment_overrides

The reason is nextest triggers a different build graph, which enforces a feature flag in serde_json dependency.

This PR enforces this feature in the dev-dependencies in datafusion-cli crate, so the test become deterministic under different test setup.

#21502 Fixed a similar issue, and also explains why not enabling it in the global dependencies inside Cargo.toml

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@Dandandan Dandandan added this pull request to the merge queue Apr 21, 2026
Merged via the queue into apache:main with commit 9a851d6 Apr 21, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants