-
Notifications
You must be signed in to change notification settings - Fork 1.9k
separate projection and alias-projection
#4232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Projection: lineitem.l_orderkey, SUM(lineitem.l_extendedprice) AS price AS __value, alias=__sq_1 | ||
| Projection: lineitem.l_orderkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problems like this indicate pushdown rule exist some bug.
|
Do we need to support such kind of usage? |
|
BTW, below is the Spark SQL's plan Another example;
|
|
Spark doesn't have alias-projection. @mingmwang We also can read Alias just contain
Spark projection just contains |
|
So we don't need projection keep alias, just expr::Alias is enough |
I am OK with removing alias from Projection. Let get some advices from other members also. |
|
close. all job finish in #4333 |
Which issue does this PR close?
Part of #3927 #2212
We should separate
projectionandalias-projection.In fact,
alias-projectionissubqueryAlias, after this job, we can easy remove the alias in projection, and replace it withsubqueryAliasRationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?