Fix builds fail with error: symbol init___rust_ctor___ctor is already defined #6495

[alamb]

Which issue does this PR close?

Closes #6495

Rationale for this change

CI / builds are failing after the update of the ctor library

What changes are included in this PR?

Ensure we only use #[ctor] once in the datafusion-optimizer library

Are these changes tested?

yes by CI

Are there any user-facing changes?

[alamb]

Something about ctor 2.1 doesn't like two ctors for a single library

[tustvold]

Not a massive fan of the use of static constructors, but as this is a pre-existing pattern 👍

[alamb]

Not a massive fan of the use of static constructors, but as this is a pre-existing pattern 👍

FWIW the only alternative I know is to do what we do in IOx and sprinkle setup in all the tests:

https://github.com/search?q=repo%3Ainfluxdata/influxdb_iox%20maybe_start_logging&type=code

e.g.

    #[test]
    fn test_panic_counter_and_logging() {
        maybe_start_logging();

Do you know a better pattern to enable logging during unit test run?

[avantgardnerio]

Not a massive fan of the use of static constructors, but as this is a pre-existing pattern +1

FWIW the only alternative I know is to do what we do in IOx and sprinkle setup in all the tests:

https://github.com/search?q=repo%3Ainfluxdata/influxdb_iox%20maybe_start_logging&type=code

e.g.

    #[test]
    fn test_panic_counter_and_logging() {
        maybe_start_logging();

Do you know a better pattern to enable logging during unit test run?

yes, one second

[avantgardnerio]

Not a massive fan of the use of static constructors, but as this is a pre-existing pattern +1

FWIW the only alternative I know is to do what we do in IOx and sprinkle setup in all the tests:

https://github.com/search?q=repo%3Ainfluxdata/influxdb_iox%20maybe_start_logging&type=code

e.g.

    #[test]
    fn test_panic_counter_and_logging() {
        maybe_start_logging();

Do you know a better pattern to enable logging during unit test run?

What about this? https://github.com/apache/arrow-datafusion/blob/201a2a903325ad4dddd94572cfd0a19287131f04/datafusion/sql/tests/integration_test.rs#LL41C7-L41C7

Oh, never mind, I see now the conversation started with not liking static constructor.