Standardize RUST_LOG configuration test setup
#6506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
r4ntix
approved these changes
Jun 2, 2023
Contributor
Author
|
Thanks for the review @r4ntix ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as it builds on #6505Which issue does this PR close?
Related to #6495 and a follow up from #6505
Rationale for this change
Basically,
[#ctor]is used to do one-time initialization of logging in the tests and it is not done consistently across the codebase, perhaps leading to issues like #6495What changes are included in this PR?
This PR moves the initialization to the main module and adds comments explaining what is going on.
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
no