chore: required at least 1 approve before merge #7226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
Member
Author
|
cc @liukun4515 |
liukun4515
approved these changes
Aug 8, 2023
alamb
approved these changes
Aug 8, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I think this is fine if other committers prefer this workflow. I have found it convenient on occasion to simply merge things prior to review to unblock CI pipelines but given the current activity of committers on DataFusion I think getting a review for such changes will be pretty fast.
Contributor
Let's try and see if it's fast enough :) |
Dandandan
approved these changes
Aug 8, 2023
This was referenced Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
It is required that PR is approve to make Merge
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?