Document and scratch directory for sqllogictest and make test specific
#7312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Tests in the `.slt` file are a sequence of query record generally starting with `CREATE` statements to populate tables | ||
| and then further queries to test the populated data (arrow-datafusion exception). | ||
| For example, the `test_files/copy.slt` file should use scratch |
Contributor
There was a problem hiding this comment.
This looks great to me! I ran into some issues needing to make sure each table had a unique subpath betwen copy/insert tests in #7294, and this would simplify that.
Contributor
Author
There was a problem hiding this comment.
Merged #7294 and I updated this PR with the changes from there
metesynnada
reviewed
Aug 18, 2023
Contributor
metesynnada
left a comment
metesynnada
left a comment
There was a problem hiding this comment.
Small typos, other than LGTM.
Co-authored-by: Metehan Yıldırım <100111937+metesynnada@users.noreply.github.com>
Contributor
Author
|
@Dandandan / @jackwener / @liukun4515 here is another example where the PR is ready to merge but I can't merge it due to the check added in #7226 Can another committer please approve this PR? |
yjshen
approved these changes
Aug 23, 2023
Contributor
Author
|
Thanks @yjshen ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #7283
Rationale for this change
@devinjdangelo added a neat
scratchconcept to sqllogictest but it is not yet documented. See discussion at #7283 (comment)What changes are included in this PR?
copy.sltto use the specific direcotryscratchdir in READMEAre these changes tested?
Yes
Are there any user-facing changes?