Run TPC-H SF10 during PR benchmarks #9822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
reviewed
Mar 27, 2024
| # Setup the TPC-H data set with a scale factor of 10 | ||
| # Setup the TPC-H data sets for scale factors 1 and 10 | ||
| ./bench.sh data tpch |
Contributor
There was a problem hiding this comment.
Does it make sense to do SF=1?
Contributor
Author
There was a problem hiding this comment.
Fair point; I guess it can be beneficial to detect minor systemic/non-linear regressions that are larger than the noise level, but smaller then the sensitivity of SF 10?
Dandandan
reviewed
Mar 27, 2024
| cd benchmarks | ||
| ./bench.sh run tpch | ||
| ./bench.sh run tpch10 |
Contributor
There was a problem hiding this comment.
Perhaps we could run tpch10_mem as well if it doesn't run OOM, or tpch_mem otherwise which should have less variance.
Contributor
Author
There was a problem hiding this comment.
Yeah I can add tpch10_mem as well.
Contributor
Author
There was a problem hiding this comment.
Ok I've added both tpch_mem10 and tpch_mem, so that we can observe and compare the noise level for each one.
Also distinguish the output file by the SF used.
Dandandan
approved these changes
Mar 27, 2024
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Apr 1, 2024
* Run TPC-H SF10 during PR benchmarks * Add memory benchmarks to the workflow Also distinguish the output file by the SF used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Progresses #5504.
Rationale for this change
Make the variance a smaller component in benchmarks by using a larger SF
and thus reduce the noise/false-positives.
What changes are included in this PR?
Run SF 10 in PR benchmarks too.
Are these changes tested?
Are there any user-facing changes?