Minor: Remove TPCH scale factor 10 from PR benchmark checks #9856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @Dandandan |
gruuya
reviewed
Mar 29, 2024
| ./bench.sh run tpch | ||
| ./bench.sh run tpch_mem | ||
| ./bench.sh run tpch10 |
Contributor
There was a problem hiding this comment.
Sorry, my bad, I meant only tpch_mem10 here and below as well (so this should remain). Actually let me open a quick PR myself.
Contributor
There was a problem hiding this comment.
This is actually what I had in mind, sorry for the confusion again: #9858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Suggested by @gruuya on #9855 (comment)
The TPCH SF10 benchmarks OOM on github runners -- #9800 (comment)
What changes are included in this PR?
Partially revert #9822 to not run TPCH
Are these changes tested?
Are there any user-facing changes?