Skip to content

Minor: Remove TPCH scale factor 10 from PR benchmark checks #9856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alamb wants to merge 1 commit into from
Closed

Minor: Remove TPCH scale factor 10 from PR benchmark checks #9856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/pr_benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ jobs:
cd benchmarks
mkdir data

# Setup the TPC-H data sets for scale factors 1 and 10
# Setup the TPC-H data sets for scale factor 1
./bench.sh data tpch
./bench.sh data tpch10

- name: Generate unique result names
run: |
Expand All @@ -46,8 +45,6 @@ jobs:

./bench.sh run tpch
./bench.sh run tpch_mem
./bench.sh run tpch10
Copy link
Contributor

@gruuya gruuya Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad, I meant only tpch_mem10 here and below as well (so this should remain). Actually let me open a quick PR myself.

Copy link
Contributor

@gruuya gruuya Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually what I had in mind, sorry for the confusion again: #9858

./bench.sh run tpch_mem10

# For some reason this step doesn't seem to propagate the env var down into the script
if [ -d "results/HEAD" ]; then
Expand Down