[Fix] (array-type) add the supported sub-type and regression #10824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/planner
carlvinhust2012
changed the title
carlvinhust2012
changed the title
carlvinhust2012
changed the title
carlvinhust2012
force-pushed
the
bug-fix
branch
3 times, most recently
from
6e8dec1 to
5b83000
Compare
cambyzju
reviewed
Jul 19, 2022
| if (!type.getPrimitiveType().isIntegerType() | ||
| && !type.getPrimitiveType().isCharFamily()) { | ||
| throw new AnalysisException("Array column just support INT/VARCHAR sub-type"); | ||
| && !type.getPrimitiveType().isCharFamily() |
Contributor
There was a problem hiding this comment.
use Type.getArraySubTypes() to check nested type of array.
Contributor
Author
There was a problem hiding this comment.
The return type of 'Type.getArraySubTypes() ' is ArrayList.
But here the 'type' is the sub-type of array, I think no need use 'getArraySubTypes()' again.
carlvinhust2012
force-pushed
the
bug-fix
branch
4 times, most recently
from
b919920 to
b7785e8
Compare
2.add regression test for the supported sub-type
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
LGTM |
miswujian
pushed a commit
to miswujian/doris
that referenced
this pull request
Jul 28, 2022
1.This pr is used for adding the supported sub-type for array which has been modified in apache#9916 2.add regression test for the supported sub-type Co-authored-by: hucheng01 <hucheng01@baidu.com>
whutpencil
pushed a commit
to whutpencil/incubator-doris
that referenced
this pull request
Jul 29, 2022
1.This pr is used for adding the supported sub-type for array which has been modified in apache#9916 2.add regression test for the supported sub-type Co-authored-by: hucheng01 <hucheng01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
2.Issue Number: close #7570
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...