[Feature-wip] support datev2 #9916
Conversation
Gabriel39
changed the title
github-actions
bot
added
area/load
Gabriel39
force-pushed
the
refactor_time_be_dev
branch
22 times, most recently
from
b2faa13 to
6cbc559
Compare
be/src/exec/olap_scan_node.cpp
Outdated
| Status OlapScanNode::change_fixed_value_range(ColumnValueRange<T>& temp_range, PrimitiveType type, | ||
| void* value, const ChangeFixedValueRangeFunc& func) { | ||
| void* value, const ChangeFixedValueRangeFunc& func, | ||
| PrimitiveType to_type) { |
There was a problem hiding this comment.
add param of to_type seems do not use ?
There was a problem hiding this comment.
This argument is added in order to meet patterns like cast(datev2 as datetimev2). Since datetimev2 has not been supported, this argument is indeed not used now.
| } | ||
| static void set_to_min(void* buf) { | ||
| // min is 0 * 16 * 32 + 1 * 32 + 1; | ||
| *reinterpret_cast<CppType*>(buf) = doris::vectorized::MIN_DATE_V2; |
There was a problem hiding this comment.
mysql seems support "0000-00-00", rethink whether we need to support the data
There was a problem hiding this comment.
The DATE type is used for values with a date part but no time part. MySQL retrieves and displays DATE values in 'YYYY-MM-DD' format. The supported range is '1000-01-01' to '9999-12-31'.
The DATETIME type is used for values that contain both date and time parts. MySQL retrieves and displays DATETIME values in 'YYYY-MM-DD hh:mm:ss' format. The supported range is '1000-01-01 00:00:00' to '9999-12-31 23:59:59'.
This is described in document[1]
There was a problem hiding this comment.
Maybe we do not support years before 1000. Although we could save it but could not support calculations. And maybe we could support it in the future.
Gabriel39
force-pushed
the
refactor_time_be_dev
branch
3 times, most recently
from
1ae65ef to
fb14fc8
Compare
Gabriel39
force-pushed
the
refactor_time_be_dev
branch
from
fb14fc8 to
b2c8650
Compare
Gabriel39
force-pushed
the
refactor_time_be_dev
branch
from
b2c8650 to
d888cd9
Compare
Gabriel39
force-pushed
the
refactor_time_be_dev
branch
from
d888cd9 to
f7271be
Compare
|
I will merge it and we can do decimal v3 based on this. |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
1.This pr is used for adding the supported sub-type for array which has been modified in #9916 2.add regression test for the supported sub-type Co-authored-by: hucheng01 <hucheng01@baidu.com>
1.This pr is used for adding the supported sub-type for array which has been modified in apache#9916 2.add regression test for the supported sub-type Co-authored-by: hucheng01 <hucheng01@baidu.com>
1.This pr is used for adding the supported sub-type for array which has been modified in apache#9916 2.add regression test for the supported sub-type Co-authored-by: hucheng01 <hucheng01@baidu.com>
3 participants
Proposed changes
Issue Number: close #9575
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...