[fix](image) fix bug that latestValidatedImageSeq may not be the second largest image id #11201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd largest image id When traversing the image files in the meta directory, it cannot be guaranteed to be traversed in the order of imageid size For example, if it traverses the image file with orders like: 3,5,4,1, then latestImageSeq is 5, but latestValidatedImageSeq is 3, which is wrong.
dataroaring
approved these changes
Jul 26, 2022
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Jul 27, 2022
…nd largest image id (apache#11201) * [fix](image) fix bug that latestValidatedImageSeq may not be the second largest image id When traversing the image files in the meta directory, it cannot be guaranteed to be traversed in the order of imageid size For example, if it traverses the image file with orders like: 3,5,4,1, then latestImageSeq is 5, but latestValidatedImageSeq is 3, which is wrong.
yiguolei
added a commit
that referenced
this pull request
Jul 27, 2022
…nd largest image id (#11201) (#11230) * [fix](image) fix bug that latestValidatedImageSeq may not be the second largest image id When traversing the image files in the meta directory, it cannot be guaranteed to be traversed in the order of imageid size For example, if it traverses the image file with orders like: 3,5,4,1, then latestImageSeq is 5, but latestValidatedImageSeq is 3, which is wrong. Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
miswujian
pushed a commit
to miswujian/doris
that referenced
this pull request
Jul 28, 2022
…nd largest image id (apache#11201) * [fix](image) fix bug that latestValidatedImageSeq may not be the second largest image id When traversing the image files in the meta directory, it cannot be guaranteed to be traversed in the order of imageid size For example, if it traverses the image file with orders like: 3,5,4,1, then latestImageSeq is 5, but latestValidatedImageSeq is 3, which is wrong.
whutpencil
pushed a commit
to whutpencil/incubator-doris
that referenced
this pull request
Jul 29, 2022
…nd largest image id (apache#11201) * [fix](image) fix bug that latestValidatedImageSeq may not be the second largest image id When traversing the image files in the meta directory, it cannot be guaranteed to be traversed in the order of imageid size For example, if it traverses the image file with orders like: 3,5,4,1, then latestImageSeq is 5, but latestValidatedImageSeq is 3, which is wrong.
Henry2SS
pushed a commit
to Henry2SS/incubator-doris
that referenced
this pull request
Sep 14, 2022
…nd largest image id (apache#11201) (apache#11230) * [fix](image) fix bug that latestValidatedImageSeq may not be the second largest image id When traversing the image files in the meta directory, it cannot be guaranteed to be traversed in the order of imageid size For example, if it traverses the image file with orders like: 3,5,4,1, then latestImageSeq is 5, but latestValidatedImageSeq is 3, which is wrong. Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #11202
Problem Summary:
When traversing the image files in the meta directory,
it cannot be guaranteed to be traversed in the order of imageid size
For example, if it traverses the image file with orders like: 3,5,4,1,
then latestImageSeq is 5, but latestValidatedImageSeq is 3, which is wrong.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...